Re: [PATCH 0/5] building git with clang/gcc address sanitizer

2017-07-10 Thread Jeff King
On Mon, Jul 10, 2017 at 04:40:42PM +0200, Lars Schneider wrote: > > If you want to see it in action, you can do: > > > > make SANITIZE=address > > ./git log -g HEAD HEAD >/dev/null > > > > which finds a bug I recently fixed (but the fix isn't in master yet). > > Do you think it would make

Re: [PATCH 0/5] building git with clang/gcc address sanitizer

2017-07-10 Thread Lars Schneider
> On 10 Jul 2017, at 15:24, Jeff King wrote: > > I mentioned recently that I sometimes run the test suite with ASan, so > here are a few tweaks to make this easier (most of which I've been > carrying in my personal config.mak for a few years). > > In my experience ASan does at

Re: [PATCH 0/5] building git with clang/gcc address sanitizer

2017-07-10 Thread Jeff King
On Mon, Jul 10, 2017 at 09:24:18AM -0400, Jeff King wrote: > You can also try: > > make SANITIZE=thread test > > but it's not clean. I poked at some of the errors, and I don't think > there a problem in practice (though they may be worth cleaning up in the > name of code hygiene). Here's an

[PATCH 0/5] building git with clang/gcc address sanitizer

2017-07-10 Thread Jeff King
I mentioned recently that I sometimes run the test suite with ASan, so here are a few tweaks to make this easier (most of which I've been carrying in my personal config.mak for a few years). In my experience ASan does at least as well as valgrind at finding memory bugs, and runs way faster. With