Re: On the nature of cover letters [WAS Re: [PATCH 0/6] Create Git/Packet.pm]

2017-11-02 Thread Stefan Beller
On Thu, Nov 2, 2017 at 1:01 AM, Jeff King wrote: > On Thu, Nov 02, 2017 at 04:48:45PM +0900, Junio C Hamano wrote: > >> Jeff King writes: >> >> > If the clutter is too much, it could also go into a git-notes ref >> > (that's not already implemented, but it seems

Re: On the nature of cover letters [WAS Re: [PATCH 0/6] Create Git/Packet.pm]

2017-11-02 Thread Jeff King
On Thu, Nov 02, 2017 at 04:48:45PM +0900, Junio C Hamano wrote: > Jeff King writes: > > > If the clutter is too much, it could also go into a git-notes ref > > (that's not already implemented, but it seems like it would be pretty > > easy to teach "git am" to do that). > > FWIW,

Re: On the nature of cover letters [WAS Re: [PATCH 0/6] Create Git/Packet.pm]

2017-11-02 Thread Junio C Hamano
Jeff King writes: > If the clutter is too much, it could also go into a git-notes ref > (that's not already implemented, but it seems like it would be pretty > easy to teach "git am" to do that). FWIW, that is what I use a notes ref "amlog" for.

Re: On the nature of cover letters [WAS Re: [PATCH 0/6] Create Git/Packet.pm]

2017-11-02 Thread Jeff King
On Wed, Nov 01, 2017 at 03:31:42PM -0700, Stefan Beller wrote: > On Wed, Nov 1, 2017 at 9:42 AM, Stefan Beller wrote: > > >> So it may make more sense just to cross-reference those merges with the > >> topics that spawned them on the mailing list. I.e., instead of copying >

Re: On the nature of cover letters [WAS Re: [PATCH 0/6] Create Git/Packet.pm]

2017-11-01 Thread Stefan Beller
On Wed, Nov 1, 2017 at 9:42 AM, Stefan Beller wrote: >> So it may make more sense just to cross-reference those merges with the >> topics that spawned them on the mailing list. I.e., instead of copying >> the cover letter contents, just record the message-id (and update it >>

Re: On the nature of cover letters [WAS Re: [PATCH 0/6] Create Git/Packet.pm]

2017-11-01 Thread Stefan Beller
On Wed, Nov 1, 2017 at 12:14 AM, Jeff King wrote: > On Mon, Oct 30, 2017 at 11:29:37AM -0700, Stefan Beller wrote: > >> > I can live with fancily-formatted cover letters. BUT. I would say if >> > your cover letter is getting quite long, you might consider whether some >> > of its

Re: On the nature of cover letters [WAS Re: [PATCH 0/6] Create Git/Packet.pm]

2017-11-01 Thread Jeff King
On Mon, Oct 30, 2017 at 11:29:37AM -0700, Stefan Beller wrote: > > I can live with fancily-formatted cover letters. BUT. I would say if > > your cover letter is getting quite long, you might consider whether some > > of its content ought to be going elsewhere (either into commit messages > >

On the nature of cover letters [WAS Re: [PATCH 0/6] Create Git/Packet.pm]

2017-10-30 Thread Stefan Beller
On Mon, Oct 30, 2017 at 11:08 AM, Jeff King wrote: > On Mon, Oct 23, 2017 at 01:26:41PM +0100, Philip Oakley wrote: > >> > Totally offtopic, but is it only me who finds these "section >> > headers" in cover letters from some people irritating and/or >> > jarring? >> >> Personally I

Re: [PATCH 0/6] Create Git/Packet.pm

2017-10-30 Thread Jeff King
On Mon, Oct 23, 2017 at 01:26:41PM +0100, Philip Oakley wrote: > > Totally offtopic, but is it only me who finds these "section > > headers" in cover letters from some people irritating and/or > > jarring? > > Personally I find that, for significant patch series, that clearly breaking > out

Re: [PATCH 0/6] Create Git/Packet.pm

2017-10-30 Thread Johannes Schindelin
Hi Christian & Junio, On Mon, 30 Oct 2017, Christian Couder wrote: > On Mon, Oct 30, 2017 at 1:38 AM, Junio C Hamano wrote: > > I've queued this from Dscho; please take it into consideration when > > you reroll. > > Yeah, I was planning to add something like that, though in

Re: [PATCH 0/6] Create Git/Packet.pm

2017-10-30 Thread Christian Couder
Hi, On Mon, Oct 30, 2017 at 1:38 AM, Junio C Hamano wrote: > I've queued this from Dscho; please take it into consideration when > you reroll. Yeah, I was planning to add something like that, though in Dscho's first email the patch was adding: +modules += Git/Packet and now

Re: [PATCH 0/6] Create Git/Packet.pm

2017-10-29 Thread Junio C Hamano
I've queued this from Dscho; please take it into consideration when you reroll. Thanks. -- >8 -- From: Johannes Schindelin Date: Sun, 29 Oct 2017 16:17:06 +0100 Subject: [PATCH] fixup! Git/Packet.pm: extract parts of t0021/rot13-filter.pl for reuse The patch

Re: [PATCH 0/6] Create Git/Packet.pm

2017-10-27 Thread Johannes Schindelin
Hi Bryan, On Thu, 26 Oct 2017, Bryan Turner wrote: > On Thu, Oct 26, 2017 at 2:07 AM, Jacob Keller wrote: > > On Wed, Oct 25, 2017 at 10:38 PM, Junio C Hamano wrote: > >> Johannes Schindelin writes: > >> > >>> Note that

Re: [PATCH 0/6] Create Git/Packet.pm

2017-10-27 Thread Johannes Schindelin
Hi Junio, On Thu, 26 Oct 2017, Junio C Hamano wrote: > Johannes Schindelin writes: > > > Note that the correct blib path starts with `C:\BuildAgent\_work` and > > the line > > > > use lib (split(/:/, $ENV{GITPERLLIB})); > > > > splits off the drive letter from

Re: [PATCH 0/6] Create Git/Packet.pm

2017-10-26 Thread Bryan Turner
On Thu, Oct 26, 2017 at 2:07 AM, Jacob Keller wrote: > On Wed, Oct 25, 2017 at 10:38 PM, Junio C Hamano wrote: >> Johannes Schindelin writes: >> >>> Note that the correct blib path starts with `C:\BuildAgent\_work` and >>>

Re: [PATCH 0/6] Create Git/Packet.pm

2017-10-26 Thread Bryan Turner
On Thu, Oct 26, 2017 at 2:07 AM, Jacob Keller wrote: > On Wed, Oct 25, 2017 at 10:38 PM, Junio C Hamano wrote: >> Johannes Schindelin writes: >> >>> Note that the correct blib path starts with `C:\BuildAgent\_work` and >>>

Re: [PATCH 0/6] Create Git/Packet.pm

2017-10-26 Thread Jacob Keller
On Wed, Oct 25, 2017 at 10:38 PM, Junio C Hamano wrote: > Johannes Schindelin writes: > >> Note that the correct blib path starts with `C:\BuildAgent\_work` and >> the line >> >> use lib (split(/:/, $ENV{GITPERLLIB})); >> >> splits off the

Re: [PATCH 0/6] Create Git/Packet.pm

2017-10-25 Thread Junio C Hamano
Johannes Schindelin writes: > Note that the correct blib path starts with `C:\BuildAgent\_work` and > the line > > use lib (split(/:/, $ENV{GITPERLLIB})); > > splits off the drive letter from the rest of the path. Obviously, this > fails to Do The Right Thing,

Re: [PATCH 0/6] Create Git/Packet.pm

2017-10-25 Thread Johannes Schindelin
Hi Christian, On Thu, 19 Oct 2017, Christian Couder wrote: > Add Git/Packet.pm from parts of t0021/rot13-filter.pl > > perl/Git/Packet.pm | 118 > This change, together with forcing t0021/rot13-filter.pl to use Git/Packet.pm, breaks the

Re: [PATCH 0/6] Create Git/Packet.pm

2017-10-23 Thread Philip Oakley
Hi Junio, From: "Junio C Hamano" Christian Couder writes: Goal Totally offtopic, but is it only me who finds these "section headers" in cover letters from some people irritating and/or jarring? Personally I find that, for significant

Re: [PATCH 0/6] Create Git/Packet.pm

2017-10-21 Thread Junio C Hamano
Christian Couder writes: > Goal > Totally offtopic, but is it only me who finds these "section headers" in cover letters from some people irritating and/or jarring? It perhaps is because I view the cover letter more as a part of conversation, not a

[PATCH 0/6] Create Git/Packet.pm

2017-10-19 Thread Christian Couder
Goal Packet related functions in Perl can be useful to write new filters or to debug or test existing filters. So instead of having them in t0021/rot13-filter.pl, let's extract them into a new Git/Packet.pm module. Links ~ This patch series has been extracted from previous "Add initial