Re: [PATCH 00/11] alternative unify appending of sob

2012-11-28 Thread Junio C Hamano
Nguyen Thai Ngoc Duy pclo...@gmail.com writes: On Mon, Nov 26, 2012 at 8:45 AM, Brandon Casey draf...@gmail.com wrote: I've integrated Duy's series with a few minor tweaks. I added a couple of additional tests to t4014 and corrected one of the tests which had incorrect behavior. I think

Re: [PATCH 00/11] alternative unify appending of sob

2012-11-26 Thread Junio C Hamano
Brandon Casey draf...@gmail.com writes: So, this series should result in s-o-b and (cherry picked from...) being appended to commit messages in a more consistent and deterministic way. For example, the decision about whether to insert a blank line before appending a s-o-b. As discussed,

Re: [PATCH 00/11] alternative unify appending of sob

2012-11-25 Thread Nguyen Thai Ngoc Duy
On Mon, Nov 26, 2012 at 8:45 AM, Brandon Casey draf...@gmail.com wrote: From: Brandon Casey bca...@nvidia.com I hate to have the battle of the patches, but I kinda prefer the append_signoff code in sequencer.c over the code in log-tree.c as a foundation to build on. So, this series is