Re: [PATCH 00/16] worktree: use git reset --hard to populate worktree

2015-07-15 Thread Duy Nguyen
On Wed, Jul 15, 2015 at 1:48 PM, Eric Sunshine sunsh...@sunshineco.com wrote: - check_linked_checkout() when trying to decide what branch is checked out assumes HEAD is always a regular file, but I do not think we have dropped the support of SYMLINK_HEAD yet. It needs to check

Re: [PATCH 00/16] worktree: use git reset --hard to populate worktree

2015-07-15 Thread Eric Sunshine
On Mon, Jul 13, 2015 at 2:36 PM, Junio C Hamano gits...@pobox.com wrote: Eric Sunshine sunsh...@sunshineco.com writes: This series eliminates git-checkout from the picture by instead employing git reset --hard[2] to populate the new worktree initially. A few comments on things I noticed while

Re: [PATCH 00/16] worktree: use git reset --hard to populate worktree

2015-07-14 Thread Duy Nguyen
On Tue, Jul 14, 2015 at 4:53 PM, Michael J Gruber g...@drmicha.warpmail.net wrote: Related to that, I'm interested in worktree list, and I'm wondering how many more worktree commands we foresee, and therefore how much refactoring should be done: Currently, the parsing of the contents of

Re: [PATCH 00/16] worktree: use git reset --hard to populate worktree

2015-07-14 Thread Michael J Gruber
Junio C Hamano venit, vidit, dixit 13.07.2015 20:36: Eric Sunshine sunsh...@sunshineco.com writes: This is a follow-on series to [1], which migrated git checkout --to functionality to git worktree add. That series continued using git checkout for the initial population of the new worktree,

Re: [PATCH 00/16] worktree: use git reset --hard to populate worktree

2015-07-14 Thread Eric Sunshine
On Tue, Jul 14, 2015 at 5:53 AM, Michael J Gruber g...@drmicha.warpmail.net wrote: Eric Sunshine sunsh...@sunshineco.com writes: This is a follow-on series to [1], which migrated git checkout --to functionality to git worktree add. That series continued using git checkout for the initial

Re: [PATCH 00/16] worktree: use git reset --hard to populate worktree

2015-07-13 Thread Junio C Hamano
Eric Sunshine sunsh...@sunshineco.com writes: This is a follow-on series to [1], which migrated git checkout --to functionality to git worktree add. That series continued using git checkout for the initial population of the new worktree, which required git-checkout to have too intimate

[PATCH 00/16] worktree: use git reset --hard to populate worktree

2015-07-11 Thread Eric Sunshine
This is a follow-on series to [1], which migrated git checkout --to functionality to git worktree add. That series continued using git checkout for the initial population of the new worktree, which required git-checkout to have too intimate knowledge that it was operating in a newly created