Re: [PATCH 00/20] object_id part 7

2017-03-20 Thread brian m. carlson
On Mon, Mar 20, 2017 at 08:14:20PM +0700, Duy Nguyen wrote: > On Sun, Mar 19, 2017 at 4:19 AM, brian m. carlson > wrote: > > This is part 7 in the continuing transition to use struct object_id. > > It feels very nice to see many ".hash" and "->hash" go away. Looking > forward to seeing you kill s

Re: [PATCH 00/20] object_id part 7

2017-03-20 Thread Duy Nguyen
On Sun, Mar 19, 2017 at 4:19 AM, brian m. carlson wrote: > This is part 7 in the continuing transition to use struct object_id. It feels very nice to see many ".hash" and "->hash" go away. Looking forward to seeing you kill sha1 in sha1_file.c, object.c and friends. That one (and read-cache) must

[PATCH 00/20] object_id part 7

2017-03-18 Thread brian m. carlson
This is part 7 in the continuing transition to use struct object_id. This series focuses on two main areas: adding two constants for the maximum hash size we'll be using (which will be suitable for allocating memory) and converting struct sha1_array to struct oid_array. The rationale for adding s