Re: [PATCH 00/29] Add blame to libgit

2017-05-24 Thread Junio C Hamano
Jeff Smith writes: > Rather than duplicate large portions of builtin/blame.c in cgit, it > would be better to shift its core functionality into libgit.a. The > functionality left in builtin/blame.c mostly relates to terminal > presentation. This was a lot more pleasant to review compared to the

Re: [PATCH 00/29] Add blame to libgit

2017-05-24 Thread Junio C Hamano
I haven't had a chance to take a deeper look, but what I saw in merge conflicts with the rest of the system made all sense to me ;-) Will take a deeper look tomorrow. Thanks.

[PATCH 00/29] Add blame to libgit

2017-05-23 Thread Jeff Smith
Rather than duplicate large portions of builtin/blame.c in cgit, it would be better to shift its core functionality into libgit.a. The functionality left in builtin/blame.c mostly relates to terminal presentation. Since RFC v2 patchset: Rebased (merged in timestamp_t changes) Reorganized to s