Re: [PATCH 02/16] refs: add methods for misc ref operations

Junio C Hamano pobox.com> writes: > > David Turner twopensource.com> writes: > > > struct ref_be { > > struct ref_be *next; > > const char *name; > > ref_transaction_commit_fn *transaction_commit; > > + > > + pack_refs_fn *pack_refs; > > + peel_ref_fn *peel_ref; > > +

Re: [PATCH 02/16] refs: add methods for misc ref operations

David Turner writes: > struct ref_be { > struct ref_be *next; > const char *name; > ref_transaction_commit_fn *transaction_commit; > + > + pack_refs_fn *pack_refs; > + peel_ref_fn *peel_ref; > + create_symref_fn *create_symref; > + > +

Re: [PATCH 02/16] refs: add methods for misc ref operations

David Turner writes: > diff --git a/cache.h b/cache.h > index 51c35c3..707455a 100644 > --- a/cache.h > +++ b/cache.h > @@ -,6 +,13 @@ extern char *oid_to_hex(const struct object_id *oid); > /* same static buffer as s > extern int interpret_branch_name(const

Re: [PATCH 02/16] refs: add methods for misc ref operations

On Fri, 2015-12-11 at 15:33 -0800, Junio C Hamano wrote: > David Turner writes: > > > diff --git a/cache.h b/cache.h > > index 51c35c3..707455a 100644 > > --- a/cache.h > > +++ b/cache.h > > @@ -,6 +,13 @@ extern char *oid_to_hex(const struct object_id > >

Re: [PATCH 02/16] refs: add methods for misc ref operations

On Fri, 2015-12-11 at 15:39 -0800, Junio C Hamano wrote: > David Turner writes: > > > struct ref_be { > > struct ref_be *next; > > const char *name; > > ref_transaction_commit_fn *transaction_commit; > > + > > + pack_refs_fn *pack_refs; > > +

Re: [PATCH 02/16] refs: add methods for misc ref operations

On Fri, 2015-12-11 at 16:23 -0800, Junio C Hamano wrote: > David Turner writes: > > > The previous review was here: > > http://permalink.gmane.org/gmane.comp.version-control.git/279062 > > > > Michael wrote: > >> Hmmm, I thought our convention was to define typedefs for

Re: [PATCH 02/16] refs: add methods for misc ref operations

David Turner writes: > The previous review was here: > http://permalink.gmane.org/gmane.comp.version-control.git/279062 > > Michael wrote: >> Hmmm, I thought our convention was to define typedefs for functions >> themselves, not for the pointer-to-function; e.g., >> >>

[PATCH 02/16] refs: add methods for misc ref operations

From: Ronnie Sahlberg Add ref backend methods for: resolve_ref_unsafe, verify_refname_available, pack_refs, peel_ref, create_symref, resolve_gitlink_ref. Signed-off-by: Ronnie Sahlberg Signed-off-by: David Turner ---