Re: [PATCH 03/12] Makefile & configure: reword outdated comment about PCRE

2017-04-15 Thread Ævar Arnfjörð Bjarmason
On Tue, Apr 11, 2017 at 12:14 PM, Jeff King wrote: > On Sat, Apr 08, 2017 at 01:24:57PM +, Ævar Arnfjörð Bjarmason wrote: > >> Reword an outdated comment which suggests that only git-grep can use >> PCRE. > > Makes sense. > >> -# Define USE_LIBPCRE if you have and want to use

Re: [PATCH 03/12] Makefile & configure: reword outdated comment about PCRE

2017-04-11 Thread Jeff King
On Sat, Apr 08, 2017 at 01:24:57PM +, Ævar Arnfjörð Bjarmason wrote: > Reword an outdated comment which suggests that only git-grep can use > PCRE. Makes sense. > -# Define USE_LIBPCRE if you have and want to use libpcre. git-grep will be > -# able to use Perl-compatible regular

[PATCH 03/12] Makefile & configure: reword outdated comment about PCRE

2017-04-08 Thread Ævar Arnfjörð Bjarmason
Reword an outdated comment which suggests that only git-grep can use PCRE. This comment was added back when PCRE support was initially added in commit 63e7e9d8b6 ("git-grep: Learn PCRE", 2011-05-09), and was true at the time. It hasn't been telling the full truth since git-log learned to use