Re: [PATCH 05/10] fast-export: move commit rewriting logic into a function for reuse

2018-11-10 Thread Jeff King
On Sat, Nov 10, 2018 at 10:23:07PM -0800, Elijah Newren wrote: > Logic to replace a filtered commit with an unfiltered ancestor is useful > elsewhere; put it into a function we can call. OK. I had to stare at it for a minute to make sure there was not an edge case with looking at "p" versus "p->p

[PATCH 05/10] fast-export: move commit rewriting logic into a function for reuse

2018-11-10 Thread Elijah Newren
Logic to replace a filtered commit with an unfiltered ancestor is useful elsewhere; put it into a function we can call. Signed-off-by: Elijah Newren --- builtin/fast-export.c | 37 ++--- 1 file changed, 22 insertions(+), 15 deletions(-) diff --git a/builtin/fast-