Re: [PATCH 05/12] log: add exhaustive tests for pattern style options & config

On Tue, Apr 11, 2017 at 12:32:57PM +0200, Ævar Arnfjörð Bjarmason wrote: > > This can be tricky since POSIX allows implementations to add arbitrary > > extensions for otherwise invalid syntax. > > For POSIX basic v.s. extended I'm relying on (|) not being > metacharacters in basic but metachars

Re: [PATCH 05/12] log: add exhaustive tests for pattern style options & config

On Tue, Apr 11, 2017 at 12:23 PM, Jeff King wrote: > On Sat, Apr 08, 2017 at 01:24:59PM +, Ævar Arnfjörð Bjarmason wrote: > >> Add exhaustive tests for how the different grep.patternType options & >> the corresponding command-line options affect git-log. >> >> Before this

Re: [PATCH 05/12] log: add exhaustive tests for pattern style options & config

On Sat, Apr 08, 2017 at 01:24:59PM +, Ævar Arnfjörð Bjarmason wrote: > Add exhaustive tests for how the different grep.patternType options & > the corresponding command-line options affect git-log. > > Before this change it was possible to patch revision.c so that the > --basic-regexp option

[PATCH 05/12] log: add exhaustive tests for pattern style options & config

Add exhaustive tests for how the different grep.patternType options & the corresponding command-line options affect git-log. Before this change it was possible to patch revision.c so that the --basic-regexp option was synonymous with --extended-regexp, and --perl-regexp wasn't recognized at all,