Re: [PATCH 05/12] pretty: save commit encoding from logmsg_reencode if the caller needs it

2013-03-17 Thread Eric Sunshine
On Fri, Mar 15, 2013 at 10:24 PM, Nguyễn Thái Ngọc Duy pclo...@gmail.com wrote: The commit encoding is parsed by logmsg_reencode, there's no need for the caller to re-parse it again. The reencoded message now have the s/have/has/ new encoding, not the original one. The caller would need to

[PATCH 05/12] pretty: save commit encoding from logmsg_reencode if the caller needs it

2013-03-15 Thread Nguyễn Thái Ngọc Duy
The commit encoding is parsed by logmsg_reencode, there's no need for the caller to re-parse it again. The reencoded message now have the new encoding, not the original one. The caller would need to read commit object again before parsing. Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com ---