Re: [PATCH 05/14] pack-revindex: express constants in terms of the_hash_algo

2018-10-09 Thread brian m. carlson
On Mon, Oct 08, 2018 at 03:44:36PM -0700, Stefan Beller wrote: > > - /* This knows the pack format -- the 20-byte trailer > > + /* This knows the pack format -- the hash trailer > > * follows immediately after the last object data. > > While at it, fix the comment style?

Re: [PATCH 05/14] pack-revindex: express constants in terms of the_hash_algo

2018-10-08 Thread Stefan Beller
> - /* This knows the pack format -- the 20-byte trailer > + /* This knows the pack format -- the hash trailer > * follows immediately after the last object data. While at it, fix the comment style? With or without the nit addressed, this patch (and patches 1 and 4) are

[PATCH 05/14] pack-revindex: express constants in terms of the_hash_algo

2018-10-08 Thread brian m. carlson
Express the various constants used in terms of the_hash_algo. Signed-off-by: brian m. carlson --- pack-revindex.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/pack-revindex.c b/pack-revindex.c index bb521cf7fb..3756ec71a8 100644 --- a/pack-revindex.c +++