Re: [PATCH 05/15] ref-filter: abstract ref format into its own struct

2017-07-13 Thread Junio C Hamano
Stefan Beller writes: >> So when somebody wants to do a "from design and explanation to >> provider to consumer", we would probably want "doc, *.h, *.c at the >> top-level and then things inside builtin/ subdirectory" order. Of >> course, on the other hand, "I do not trust

Re: [PATCH 05/15] ref-filter: abstract ref format into its own struct

2017-07-13 Thread Stefan Beller
On Thu, Jul 13, 2017 at 2:32 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >> Stefan Beller writes: >> >>> On Thu, Jul 13, 2017 at 8:01 AM, Jeff King wrote: >>> builtin/branch.c | 14 +++---

Re: [PATCH 05/15] ref-filter: abstract ref format into its own struct

2017-07-13 Thread Junio C Hamano
Junio C Hamano writes: > Stefan Beller writes: > >> On Thu, Jul 13, 2017 at 8:01 AM, Jeff King wrote: >> >>> builtin/branch.c | 14 +++--- >>> builtin/for-each-ref.c | 22 -- >>> builtin/tag.c |

Re: [PATCH 05/15] ref-filter: abstract ref format into its own struct

2017-07-13 Thread Junio C Hamano
Stefan Beller writes: > On Thu, Jul 13, 2017 at 8:01 AM, Jeff King wrote: > >> builtin/branch.c | 14 +++--- >> builtin/for-each-ref.c | 22 -- >> builtin/tag.c | 30 -- >>

Re: [PATCH 05/15] ref-filter: abstract ref format into its own struct

2017-07-13 Thread Stefan Beller
On Thu, Jul 13, 2017 at 8:01 AM, Jeff King wrote: > builtin/branch.c | 14 +++--- > builtin/for-each-ref.c | 22 -- > builtin/tag.c | 30 -- > builtin/verify-tag.c | 12 ++-- > ref-filter.c

[PATCH 05/15] ref-filter: abstract ref format into its own struct

2017-07-13 Thread Jeff King
The ref-filter module provides routines for formatting a ref for output. The fundamental interface for the format is a "const char *" containing the format, and any additional options need to be passed to each invocation of show_ref_array_item. Instead, let's make a ref_format struct that holds