Re: [PATCH 06/10] setup: refactor repo format reading and verification

2016-03-03 Thread Jeff King
On Thu, Mar 03, 2016 at 08:19:22PM +0700, Duy Nguyen wrote: > On Tue, Mar 1, 2016 at 9:42 PM, Jeff King wrote: > > - for (i = 0; i < unknown_extensions.nr; i++) > > - warning("unknown repository extension: %s", > > -

Re: [PATCH 06/10] setup: refactor repo format reading and verification

2016-03-03 Thread Duy Nguyen
On Tue, Mar 1, 2016 at 9:42 PM, Jeff King wrote: > - for (i = 0; i < unknown_extensions.nr; i++) > - warning("unknown repository extension: %s", > - unknown_extensions.items[i].string); > - *nongit_ok =

Re: [PATCH 06/10] setup: refactor repo format reading and verification

2016-03-01 Thread Jeff King
On Tue, Mar 01, 2016 at 04:20:06PM -0500, David Turner wrote: > On Tue, 2016-03-01 at 09:42 -0500, Jeff King wrote: > > +/* > > + * Read the repository format characteristics from the config file > > "path". If > > + * the version cannot be extracted from the file for any reason, the > > version

Re: [PATCH 06/10] setup: refactor repo format reading and verification

2016-03-01 Thread David Turner
On Tue, 2016-03-01 at 09:42 -0500, Jeff King wrote: > +/* > + * Read the repository format characteristics from the config file > "path". If > + * the version cannot be extracted from the file for any reason, the > version > + * field will be set to -1, and all other fields are undefined. > + */ >

[PATCH 06/10] setup: refactor repo format reading and verification

2016-03-01 Thread Jeff King
When we want to know if we're in a git repository of reasonable vintage, we can call check_repository_format_gently(), which does three things: 1. Reads the config from the .git/config file. 2. Verifies that the version info we read is sane. 3. Writes some global variables based on this.