Re: [PATCH 09/11] multi-pack-index: verify object offsets

2018-09-07 Thread Derrick Stolee
On 9/6/2018 8:34 PM, Eric Sunshine wrote: On Wed, Sep 5, 2018 at 10:46 AM Derrick Stolee via GitGitGadget wrote: Replace the BUG() statement with a die() statement, now that we may hit a bad pack-int-id during a 'verify' command on a corrupt multi-pack-index, and it is covered by a test.

Re: [PATCH 09/11] multi-pack-index: verify object offsets

2018-09-06 Thread Eric Sunshine
On Wed, Sep 5, 2018 at 10:46 AM Derrick Stolee via GitGitGadget wrote: > Replace the BUG() statement with a die() statement, now that we > may hit a bad pack-int-id during a 'verify' command on a corrupt > multi-pack-index, and it is covered by a test. > > Signed-off-by: Derrick Stolee > --- >

[PATCH 09/11] multi-pack-index: verify object offsets

2018-09-05 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee The 'git multi-pack-index verify' command must verify the object offsets stored in the multi-pack-index are correct. There are two ways the offset chunk can be incorrect: the pack-int-id and the object offset. Replace the BUG() statement with a die() statement, now that we