Re: [PATCH 1/1] fsmonitor: don't fill bitmap with entries to be removed

2019-10-07 Thread William Baker
On 10/3/19 4:36 PM, Junio C Hamano wrote: >> +if (pos >= istate->cache_nr) >> +BUG("fsmonitor_dirty has more entries than the index >> (%"PRIuMAX" >= %"PRIuMAX")", >> +(uintmax_t)pos, (uintmax_t)istate->cache_nr); > > This is how we show size_t values without usin

Re: [PATCH 1/1] fsmonitor: don't fill bitmap with entries to be removed

2019-10-03 Thread Junio C Hamano
"William Baker via GitGitGadget" writes: > create mode 100755 t/t7519/fsmonitor-env > ... > + if (pos >= istate->cache_nr) > + BUG("fsmonitor_dirty has more entries than the index > (%"PRIuMAX" >= %"PRIuMAX")", > + (uintmax_t)pos, (uintmax_t)istate->cache_nr); T

[PATCH 1/1] fsmonitor: don't fill bitmap with entries to be removed

2019-10-03 Thread William Baker via GitGitGadget
From: William Baker While doing some testing with fsmonitor enabled I found that git commands would segfault after staging and unstaging an untracked file. Looking at the crash it appeared that fsmonitor_ewah_callback was attempting to adjust bits beyond the bounds of the index cache. Digging i