Re: [PATCH 1/1] tests: Allow customization of how say_color() prints

2012-12-17 Thread Junio C Hamano
Ramsay Jones ram...@ramsay1.demon.co.uk writes: Junio C Hamano wrote: ... Why does your printf die in the first place??? I really don't know. ... Sorry for wasting your time. Not a waste. I was hoping somebody (not necessarily you) may be able to come up with a cleaner solution.

[PATCH 1/1] tests: Allow customization of how say_color() prints

2012-12-15 Thread Ramsay Jones
Since commit 7bc0911d (test-lib: Fix say_color () not to interpret \a\b\c in the message, 11-10-2012), the --no-color version of say_color() has been using the (bash builtin) printf function, rather than echo, to print the testsuite output. Due to an intermittent (and rare) failure of the printf

Re: [PATCH 1/1] tests: Allow customization of how say_color() prints

2012-12-15 Thread Junio C Hamano
Ramsay Jones ram...@ramsay1.demon.co.uk writes: diff --git a/t/test-lib.sh b/t/test-lib.sh index f50f834..9dcf3c1 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -202,6 +202,15 @@ do esac done +if test -z $GIT_TEST_PRINT +then + GIT_TEST_PRINT=printf %s +fi +if test -z