Re: [PATCH 1/2] Simplify tracing code by removing trace key normalization concept

Junio C Hamano writes: > The thought behind the change flows much better in the above > explanation than your four-bullet list (which a reader would often > assume are parallel and orthogonal). "Remove this, because it is > not used" is the primary thing for this step, and

Re: [PATCH 1/2] Simplify tracing code by removing trace key normalization concept

Gennady Kupava writes: >> The usual style comment on the subject applies here. > > Oh sure, 50 characters. 'Remove trace key normalization concept' would > be better? I was referring to #summary-section of Documentation/SubmittingPatches The first line of the

Re: [PATCH 1/2] Simplify tracing code by removing trace key normalization concept

re sense now? Gennady On 19 November 2017 at 02:19, Junio C Hamano <gits...@pobox.com> wrote: > gennady.kup...@gmail.com writes: > >> Subject: Re: [PATCH 1/2] Simplify tracing code by removing trace key >> normalization concept > > The usual style comment on the s

Re: [PATCH 1/2] Simplify tracing code by removing trace key normalization concept

gennady.kup...@gmail.com writes: > Subject: Re: [PATCH 1/2] Simplify tracing code by removing trace key > normalization concept The usual style comment on the subject applies here. > From: Gennady Kupava <gkup...@bloomberg.net> > > - to implement efficient trac

[PATCH 1/2] Simplify tracing code by removing trace key normalization concept

From: Gennady Kupava - to implement efficient traces with normalization, normalization implementation should be moved to header. as it seems better to not overload header file with this normalization logic, suggestion is just to remove it - different macro exist