On 2014-11-15 08.26, Michael Haggerty wrote:
The whole thing looks good to me, some minor comments below
git_config_set() copies the permissions from the old config file to
the new one. This is a good change in and of itself, but it interacts
badly with create_default_files()'s sloppiness,
On 11/15/2014 01:06 PM, Torsten Bögershausen wrote:
On 2014-11-15 08.26, Michael Haggerty wrote:
The whole thing looks good to me, some minor comments below
git_config_set() copies the permissions from the old config file to
the new one. This is a good change in and of itself, but it interacts
Since time immemorial, the test of whether to set core.filemode has
been done by trying to toggle the u+x bit on $GIT_DIR/config and then
testing whether the change took. It is somewhat odd to use the
config file for this test, but whatever.
The test code didn't set the u+x bit back to its
3 matches
Mail list logo
