Re: [PATCH 1/2] git-svn: search --authors-prog in PATH too

2018-03-05 Thread Andreas Heiduk
Am 05.03.2018 um 20:48 schrieb Andreas Heiduk: > Am 05.03.2018 um 18:52 schrieb Eric Wong: >> Thanks both, I've queued 1/2 up with Eric S's edits at svn/authors-prog. >> I'm not yet convinced 2/2 is a good change, however. > > I'm not sure which direction your argument points to: Do you object to

Re: [PATCH 1/2] git-svn: search --authors-prog in PATH too

2018-03-05 Thread Andreas Heiduk
Am 05.03.2018 um 18:52 schrieb Eric Wong: > > Thanks both, I've queued 1/2 up with Eric S's edits at svn/authors-prog. > I'm not yet convinced 2/2 is a good change, however. I'm not sure which direction your argument points to: Do you object to a $PATH search at all? Or would you like to

Re: [PATCH 1/2] git-svn: search --authors-prog in PATH too

2018-03-05 Thread Eric Wong
Eric Sunshine wrote: > On Sun, Mar 4, 2018 at 6:22 AM, Andreas Heiduk wrote: > > In 36db1eddf9 ("git-svn: add --authors-prog option", 2009-05-14) the path > > to authors-prog was made absolute because git-svn changes the current > > directoy in some

Re: [PATCH 1/2] git-svn: search --authors-prog in PATH too

2018-03-04 Thread Eric Sunshine
On Sun, Mar 4, 2018 at 6:22 AM, Andreas Heiduk wrote: > In 36db1eddf9 ("git-svn: add --authors-prog option", 2009-05-14) the path > to authors-prog was made absolute because git-svn changes the current > directoy in some situations. This makes sense if the program is part of

[PATCH 1/2] git-svn: search --authors-prog in PATH too

2018-03-04 Thread Andreas Heiduk
In 36db1eddf9 ("git-svn: add --authors-prog option", 2009-05-14) the path to authors-prog was made absolute because git-svn changes the current directoy in some situations. This makes sense if the program is part of the repository but prevents searching via $PATH. The old behaviour is still