Re: [PATCH 1/2] notes: don't expand qualified refs in expand_notes_ref

2015-09-22 Thread Jacob Keller
On Tue, Sep 22, 2015 at 11:37 AM, Junio C Hamano wrote: > Jacob Keller writes: > >> The other issue here is that expand_notes_ref is called on the --ref >> argument waaay before the current code even decides if the operation >> is "read" or "write". Thus we'd have to break this out and handle >>

Re: [PATCH 1/2] notes: don't expand qualified refs in expand_notes_ref

2015-09-22 Thread Junio C Hamano
Jacob Keller writes: > The other issue here is that expand_notes_ref is called on the --ref > argument waaay before the current code even decides if the operation > is "read" or "write". Thus we'd have to break this out and handle > things very differently. I think you hit the right nail here.

Re: [PATCH 1/2] notes: don't expand qualified refs in expand_notes_ref

2015-09-22 Thread Jacob Keller
On Tue, Sep 22, 2015 at 7:17 AM, Junio C Hamano wrote: > Calls expand_notes_ref() made on a command line argument that > specifies the source (which I think is similar to what the other > recent topic calls "read-only") should be made to calls to a more > lenient version (and you can start with ge

Re: [PATCH 1/2] notes: don't expand qualified refs in expand_notes_ref

2015-09-22 Thread Jacob Keller
On Tue, Sep 22, 2015 at 7:17 AM, Junio C Hamano wrote: > The current code before your patch limits the allowed pair of notes > trees by insisting that both appear as the tips of refs somewhere in > refs/notes/*. For allowing to merge from outside refs/notes/, you > need to loosen the location the

Re: [PATCH 1/2] notes: don't expand qualified refs in expand_notes_ref

2015-09-22 Thread Junio C Hamano
Jacob Keller writes: > I never got any better suggestion on how to allow the behavior > desired, which is to enable merging from a non-notes location, in > order to provide a standard location for remote notes, ie: > refs/remote-notes// Step back a bit and think again. I think you are blinded b

Re: [PATCH 1/2] notes: don't expand qualified refs in expand_notes_ref

2015-09-21 Thread Jacob Keller
On Wed, Sep 16, 2015 at 3:34 PM, Junio C Hamano wrote: > Jacob Keller writes: > >> From: Jacob Keller >> >> The documentation for --refs says that it will treat unqualified refs as >> under refs/notes. Current behavior is to prefix refs/notes to all >> strings that do not start with refs/notes o

Re: [PATCH 1/2] notes: don't expand qualified refs in expand_notes_ref

2015-09-16 Thread Jacob Keller
On Wed, Sep 16, 2015 at 3:34 PM, Junio C Hamano wrote: > Jacob Keller writes: > >> From: Jacob Keller >> >> The documentation for --refs says that it will treat unqualified refs as >> under refs/notes. Current behavior is to prefix refs/notes to all >> strings that do not start with refs/notes o

Re: [PATCH 1/2] notes: don't expand qualified refs in expand_notes_ref

2015-09-16 Thread Junio C Hamano
Jacob Keller writes: > From: Jacob Keller > > The documentation for --refs says that it will treat unqualified refs as > under refs/notes. Current behavior is to prefix refs/notes to all > strings that do not start with refs/notes or notes/, resulting in > performing actions on refs such as "ref

[PATCH 1/2] notes: don't expand qualified refs in expand_notes_ref

2015-09-16 Thread Jacob Keller
From: Jacob Keller The documentation for --refs says that it will treat unqualified refs as under refs/notes. Current behavior is to prefix refs/notes to all strings that do not start with refs/notes or notes/, resulting in performing actions on refs such as "refs/notes/refs/foo/bar" instead of a