Re: [PATCH 1/2] pathspec: allow querying for attributes

2017-03-13 Thread Stefan Beller
>> +test_expect_success 'fail if attr magic is used places not implemented' ' >> + # The main purpose of this test is to check that we actually fail >> + # when you attempt to use attr magic in commands that do not implement >> + # attr magic. This test does not advocate git-add to

Re: [PATCH 1/2] pathspec: allow querying for attributes

2017-03-12 Thread Junio C Hamano
Brandon Williams writes: > +struct attr_check *attr_check_dup(const struct attr_check *check) > +{ > + struct attr_check *ret; > + > + if (!check) > + return NULL; > + > + ret = attr_check_alloc(); > + > + ret->nr = check->nr; > + ret->alloc =

Re: [PATCH 1/2] pathspec: allow querying for attributes

2017-03-10 Thread Brandon Williams
On 03/09, Jonathan Tan wrote: > On 03/09/2017 01:07 PM, Brandon Williams wrote: > >diff --git a/Documentation/glossary-content.txt > >b/Documentation/glossary-content.txt > >index fc9320e59..5c32d1905 100644 > >--- a/Documentation/glossary-content.txt > >+++ b/Documentation/glossary-content.txt >

Re: [PATCH 1/2] pathspec: allow querying for attributes

2017-03-09 Thread Jonathan Tan
On 03/09/2017 01:07 PM, Brandon Williams wrote: diff --git a/Documentation/glossary-content.txt b/Documentation/glossary-content.txt index fc9320e59..5c32d1905 100644 --- a/Documentation/glossary-content.txt +++ b/Documentation/glossary-content.txt @@ -384,6 +384,26 @@ full pathname may have

[PATCH 1/2] pathspec: allow querying for attributes

2017-03-09 Thread Brandon Williams
The pathspec mechanism is extended via the new ":(attr:eol=input)pattern/to/match" syntax to filter paths so that it requires paths to not just match the given pattern but also have the specified attrs attached for them to be chosen. Based on a patch by Stefan Beller