Re: [PATCH 1/2] push: Fully test --recurse-submodules on command line overrides config

2015-12-17 Thread Junio C Hamano
Stefan Beller writes: >>> This looks good to me. >>> >> Thanks. Does "This" refer to 1/2 alone or the whole series? > > Yes. :) > > "This" is applicable to both patches. We had the discussion on 2/2 about me > misreading a line a few days earlier, but apart from that it looked good, too. Thanks

Re: [PATCH 1/2] push: Fully test --recurse-submodules on command line overrides config

2015-12-16 Thread Stefan Beller
On Wed, Dec 16, 2015 at 2:41 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> On Thu, Dec 3, 2015 at 5:10 AM, Mike Crowe wrote: >>> t5531 only checked that the push.recurseSubmodules config option was >>> overridden by passing --recurse-submodules=check on the command line. >>> Add new tes

Re: [PATCH 1/2] push: Fully test --recurse-submodules on command line overrides config

2015-12-16 Thread Junio C Hamano
Stefan Beller writes: > On Thu, Dec 3, 2015 at 5:10 AM, Mike Crowe wrote: >> t5531 only checked that the push.recurseSubmodules config option was >> overridden by passing --recurse-submodules=check on the command line. >> Add new tests for overriding with --recurse-submodules=no, >> --no-recurse

Re: [PATCH 1/2] push: Fully test --recurse-submodules on command line overrides config

2015-12-16 Thread Stefan Beller
On Thu, Dec 3, 2015 at 5:10 AM, Mike Crowe wrote: > t5531 only checked that the push.recurseSubmodules config option was > overridden by passing --recurse-submodules=check on the command line. > Add new tests for overriding with --recurse-submodules=no, > --no-recurse-submodules and --recurse-subm

[PATCH 1/2] push: Fully test --recurse-submodules on command line overrides config

2015-12-03 Thread Mike Crowe
t5531 only checked that the push.recurseSubmodules config option was overridden by passing --recurse-submodules=check on the command line. Add new tests for overriding with --recurse-submodules=no, --no-recurse-submodules and --recurse-submodules=push too. Also correct minor typo in test commit me