Re: [PATCH 1/2] ref-filter: mark a file-local symbol as static

On 02/03/18 17:19, Junio C Hamano wrote: > Ramsay Jones writes: > >> Junio, do you want me to re-roll, or would you mind tweaking the >> commit message while queueing? > > Perfect timing ;-) I was about to get to these two patches. Here > is what is queued.

Re: [PATCH 1/2] ref-filter: mark a file-local symbol as static

Ramsay Jones writes: > Junio, do you want me to re-roll, or would you mind tweaking the > commit message while queueing? Perfect timing ;-) I was about to get to these two patches. Here is what is queued. commit 2d7cb07e3718d0af6547e2abb35f9cff9b10c1f5 Author:

Re: [PATCH 1/2] ref-filter: mark a file-local symbol as static

On 02/03/18 03:59, Jonathan Nieder wrote: > Hi, > > Ramsay Jones wrote: > >> Commit fcfba37337 ('ref-filter: make "--contains " less chatty if >> is invalid', 2018-02-23) added the add_str_to_commit_list() >> function, which causes sparse to issue a "... not declared. Should it >> be static?"

Re: [PATCH 1/2] ref-filter: mark a file-local symbol as static

Hi, Ramsay Jones wrote: > Commit fcfba37337 ('ref-filter: make "--contains " less chatty if > is invalid', 2018-02-23) added the add_str_to_commit_list() > function, which causes sparse to issue a "... not declared. Should it > be static?" warning for that symbol. Thanks for catching it! > In

[PATCH 1/2] ref-filter: mark a file-local symbol as static

Commit fcfba37337 ('ref-filter: make "--contains " less chatty if is invalid', 2018-02-23) added the add_str_to_commit_list() function, which causes sparse to issue a "... not declared. Should it be static?" warning for that symbol. In order to suppress the warning, mark that function as