Re: [PATCH 1/2] ref-filter: split ref_kind_from_filter

2016-10-19 Thread Jeff King
On Wed, Oct 19, 2016 at 02:23:41PM -0700, Junio C Hamano wrote: > Jeff King <p...@peff.net> writes: > > > Subject: Re: [PATCH 1/2] ref-filter: split ref_kind_from_filter > > I think you meant ref_kind_from_refname() ;-) > > Looks like a good idea. Heh, I

Re: [PATCH 1/2] ref-filter: split ref_kind_from_filter

2016-10-19 Thread Junio C Hamano
Jeff King <p...@peff.net> writes: > Subject: Re: [PATCH 1/2] ref-filter: split ref_kind_from_filter I think you meant ref_kind_from_refname() ;-) Looks like a good idea. > This function does two things: if we know we are filtering > only a certain kind of ref, then we can i

[PATCH 1/2] ref-filter: split ref_kind_from_filter

2016-10-19 Thread Jeff King
This function does two things: if we know we are filtering only a certain kind of ref, then we can immediately know that we have that kind. If not, then we compute the kind from the fully-qualified refname. The latter half is useful for other callers; let's split it out. Signed-off-by: Jeff King