Re: [PATCH 1/2] [submodule] handle multibyte characters in name

2013-06-12 Thread Phil Hord
On Tue, Jun 11, 2013 at 7:04 PM, Fredrik Gustafsson wrote: > Bugg reported here: > http://thread.gmane.org/gmane.comp.version-control.git/218922/focus=226791 > > Note that newline (\n) is still not supported and will not be until the > sh-script is replaced by something in an other language. This

Re: [PATCH 1/2] submodule: handle multibyte characters in name

2013-06-12 Thread Fredrik Gustafsson
On Wed, Jun 12, 2013 at 03:57:52PM -0700, Junio C Hamano wrote: > Jens Lehmann writes: > > > Hmm, I just came around to test that patch, and for me the new > > test even succeeds without the changes to module_list(). So I'm > > not convinced yet what we are fixing here ;-) > > My guess is that y

Re: [PATCH 1/2] submodule: handle multibyte characters in name

2013-06-12 Thread Junio C Hamano
Jens Lehmann writes: > Hmm, I just came around to test that patch, and for me the new > test even succeeds without the changes to module_list(). So I'm > not convinced yet what we are fixing here ;-) My guess is that you have core.quotepaths set to false. > The original poster reported that the

Re: [PATCH 1/2] submodule: handle multibyte characters in name

2013-06-12 Thread Jens Lehmann
Am 12.06.2013 23:06, schrieb Junio C Hamano: > Fredrik Gustafsson writes: > >> Bugg reported here: >> http://thread.gmane.org/gmane.comp.version-control.git/218922/focus=226791 > > The URL is nice supplemental info as footnote, but please write log > message in a way that a reader can understand

Re: [PATCH 1/2] submodule: handle multibyte characters in name

2013-06-12 Thread Junio C Hamano
Fredrik Gustafsson writes: > Bugg reported here: > http://thread.gmane.org/gmane.comp.version-control.git/218922/focus=226791 The URL is nice supplemental info as footnote, but please write log message in a way that a reader can understand without going there. In this case, it wouldn't be so har

[PATCH 1/2] [submodule] handle multibyte characters in name

2013-06-11 Thread Fredrik Gustafsson
Bugg reported here: http://thread.gmane.org/gmane.comp.version-control.git/218922/focus=226791 Note that newline (\n) is still not supported and will not be until the sh-script is replaced by something in an other language. This however let us to use mostly all other strange characters. Signed-of