Re: [PATCH 1/2] symlinks: remove PATH_MAX limitation

2014-07-11 Thread Junio C Hamano
Karsten Blees writes: > Am 07.07.2014 20:30, schrieb Junio C Hamano: >> Karsten Blees writes: >> >> The above cache_def_free(cache) does not free the cache itself, but >> only its associated data, so the name cache_def_free() is somewhat >> misleading. >> > > You already merged this to master

Re: [PATCH 1/2] symlinks: remove PATH_MAX limitation

2014-07-11 Thread Karsten Blees
Am 07.07.2014 20:30, schrieb Junio C Hamano: > Karsten Blees writes: > > The above cache_def_free(cache) does not free the cache itself, but > only its associated data, so the name cache_def_free() is somewhat > misleading. > You already merged this to master ("kb/path-max-must-go" lol), should

Re: [PATCH 1/2] symlinks: remove PATH_MAX limitation

2014-07-07 Thread Junio C Hamano
Karsten Blees writes: > 'git checkout' fails if a directory is longer than PATH_MAX, because the > lstat_cache in symlinks.c checks if the leading directory exists using > PATH_MAX-bounded string operations. > > Remove the limitation by using strbuf instead. Good. > diff --git a/cache.h b/cache

Re: [msysGit] [PATCH 1/2] symlinks: remove PATH_MAX limitation

2014-07-04 Thread Johannes Schindelin
Hi, On Sat, 5 Jul 2014, Karsten Blees wrote: > 'git checkout' fails if a directory is longer than PATH_MAX, because the > lstat_cache in symlinks.c checks if the leading directory exists using > PATH_MAX-bounded string operations. > > Remove the limitation by using strbuf instead. > > Signed-of

[PATCH 1/2] symlinks: remove PATH_MAX limitation

2014-07-04 Thread Karsten Blees
'git checkout' fails if a directory is longer than PATH_MAX, because the lstat_cache in symlinks.c checks if the leading directory exists using PATH_MAX-bounded string operations. Remove the limitation by using strbuf instead. Signed-off-by: Karsten Blees --- This fixes a bug on Windows with lo