Re: [PATCH 1/2] t7406: correct depth test in shallow test

Stefan Beller writes: > The depth of 2 I chose originally turns out to be a lucky > accident too, as the depth from "Commit 2" is 2, > so that we would observe the same depth no matter if > a --depth 2 was given and working or not. > > I'll redo this test (as 2 tests, one is

Re: [PATCH 1/2] t7406: correct depth test in shallow test

On Thu, Jul 28, 2016 at 11:47 AM, Stefan Beller wrote: > On Thu, Jul 28, 2016 at 11:39 AM, Junio C Hamano wrote: >> Stefan Beller writes: >> >>> We used to ask for 3 changes and tested for having 1, so the test >>> seems broken. >> >> I

Re: [PATCH 1/2] t7406: correct depth test in shallow test

On Thu, Jul 28, 2016 at 11:39 AM, Junio C Hamano wrote: > Stefan Beller writes: > >> We used to ask for 3 changes and tested for having 1, so the test >> seems broken. > > I am not sure what to think of "seems broken". When asking for depth 3, I would

Re: [PATCH 1/2] t7406: correct depth test in shallow test

Stefan Beller writes: > We used to ask for 3 changes and tested for having 1, so the test > seems broken. I am not sure what to think of "seems broken". Asking for 3 and having 1 is broken in what way? Should we be expecting for 3 because we asked for that many? Should we

[PATCH 1/2] t7406: correct depth test in shallow test

We used to ask for 3 changes and tested for having 1, so the test seems broken. Correct the test by using test_line_count that exists in the test suite. Signed-off-by: Stefan Beller --- t/t7406-submodule-update.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)