Re: [PATCH 1/2] test-lib: quote TRASH_DIRECTORY

2016-03-04 Thread Jeff King
On Fri, Mar 04, 2016 at 02:03:15PM +0100, Michael J Gruber wrote: > >> -test ! -z "$debug" || remove_trash=$TRASH_DIRECTORY > >> +test ! -z "$debug" || remove_trash="$TRASH_DIRECTORY" > > > > I don't think this does anything. The shell doesn't do whitespace > > splitting on the right-hand side of

Re: [PATCH 1/2] test-lib: quote TRASH_DIRECTORY

2016-03-04 Thread Michael J Gruber
Jeff King venit, vidit, dixit 04.03.2016 12:51: > On Fri, Mar 04, 2016 at 11:53:49AM +0100, Michael J Gruber wrote: > >> We always quote $TRASH_DIRECTORY to guard against funky path names. Do >> so in one more spot >> >> Signed-off-by: Michael J Gruber >> --- >> t/test-lib.sh | 2 +- >> 1 file c

Re: [PATCH 1/2] test-lib: quote TRASH_DIRECTORY

2016-03-04 Thread Jeff King
On Fri, Mar 04, 2016 at 11:53:49AM +0100, Michael J Gruber wrote: > We always quote $TRASH_DIRECTORY to guard against funky path names. Do > so in one more spot > > Signed-off-by: Michael J Gruber > --- > t/test-lib.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/t/

[PATCH 1/2] test-lib: quote TRASH_DIRECTORY

2016-03-04 Thread Michael J Gruber
We always quote $TRASH_DIRECTORY to guard against funky path names. Do so in one more spot Signed-off-by: Michael J Gruber --- t/test-lib.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/test-lib.sh b/t/test-lib.sh index 0b47eb6..8957916 100644 --- a/t/test-lib.sh +++ b/t