Re: [PATCH 1/3] checkout: describe_detached_head: remove 3dots after committish

2017-11-09 Thread Philip Oakley
From: "Junio C Hamano" Sent: Wednesday, November 08, 2017 1:59 AM "Philip Oakley" writes: But... ... This change causes quite a few tests to fall over; however, they all have truncated-something-longer-ellipses in their raw-diff-output expected

Re: [PATCH 1/3] checkout: describe_detached_head: remove 3dots after committish

2017-11-07 Thread Junio C Hamano
"Philip Oakley" writes: > But... >> ... >> This change causes quite a few tests to fall over; however, they >> all have truncated-something-longer-ellipses in their >> raw-diff-output expected sections, and removing the ellipses >> from there makes the tests pass again, :-)

Re: [PATCH 1/3] checkout: describe_detached_head: remove 3dots after committish

2017-11-07 Thread Philip Oakley
From: "Ann T Ropea" Thanks for all the feedback provided! I'd like to summarise what consensus we have reached so far and then propose a way forward: * we'll use the term "ellipsis (pl. ellipses)" for what's been referred to as "3dots", "n-dots", "many dots" and so

Re: [PATCH 1/3] checkout: describe_detached_head: remove 3dots after committish

2017-11-06 Thread Ann T Ropea
Thanks for all the feedback provided! I'd like to summarise what consensus we have reached so far and then propose a way forward: * we'll use the term "ellipsis (pl. ellipses)" for what's been referred to as "3dots", "n-dots", "many dots" and so forth * we would like to use

Re: [PATCH 1/3] checkout: describe_detached_head: remove 3dots after committish

2017-11-06 Thread Junio C Hamano
Ann T Ropea writes: > Lest we confuse the meticulous observer, we ought to retire the 3dots in > the circumstances described above. Yes, as I said in my response to 3/3, I think it is a good goal to avoid n-dots used as a "here we truncated something longer" sign, which was a

Re: [PATCH 1/3] checkout: describe_detached_head: remove 3dots after committish

2017-11-06 Thread Philip Oakley
From: "Junio C Hamano" Ann T Ropea writes: This could be confusing not only for novices; in either case, no range should be insinuated by describe_detached_head. We actually do not insinuate any range in these output. These dots denote "truncated at

Re: [PATCH 1/3] checkout: describe_detached_head: remove 3dots after committish

2017-11-05 Thread Junio C Hamano
Ann T Ropea writes: > This could be confusing not only for novices; in either case, no range > should be insinuated by describe_detached_head. We actually do not insinuate any range in these output. These dots denote "truncated at the end, instead of giving full length."

[PATCH 1/3] checkout: describe_detached_head: remove 3dots after committish

2017-11-05 Thread Ann T Ropea
When a committish, C, is immediately followed by 3dots (...) which are, in turn, not followed by another committish, we are usually asking for the revision range C...HEAD, which is known as the symmetric difference of C and HEAD. When describe_detached_head is invoked, it prints the committish