Eric Sunshine writes:
> Paul Tan writes:
>
> >> Remi LESPINET writes:
> >> + tmp_name=${2-"temporary"}
> >
> > I don't think the quotes are required. Also, I don't feel good about
> > swapping the order of the arguments to git-checkout. (or making $2 an
> > optional argument). As the patc
On Thu, May 28, 2015 at 3:09 PM, Eric Sunshine wrote:
> On Tue, May 26, 2015 at 5:32 PM, Remi Lespinet
> wrote:
>> +setup_temporary_branch () {
>> + tmp_name=${2-"temporary"}
I forgot to mention the broken &&-chain here. Although the missing &&
doesn't actively hurt the function today, som
On Tue, May 26, 2015 at 5:32 PM, Remi Lespinet
wrote:
> Add new functions to keep the setup cleaner:
> - setup_temporary_branch: creates a new branch, check it out
>and automatically delete it after the test is over
> - setup_fixed_branch: creates a fixed branch, which can be re-used
>in
On Thu, May 28, 2015 at 9:10 AM, Paul Tan wrote:
> Take these comments/suggestions with a pinch of salt because I'm not
> that experienced with the code base as well ;-).
I agree with pretty much all of your review comments. See below for a
minor addenda.
> On Wed, May 27, 2015 at 5:32 AM, Remi
Hi,
Take these comments/suggestions with a pinch of salt because I'm not
that experienced with the code base as well ;-).
On Wed, May 27, 2015 at 5:32 AM, Remi Lespinet
wrote:
> Add new functions to keep the setup cleaner:
> - setup_temporary_branch: creates a new branch, check it out
>and
Add new functions to keep the setup cleaner:
- setup_temporary_branch: creates a new branch, check it out
and automatically delete it after the test is over
- setup_fixed_branch: creates a fixed branch, which can be re-used
in later tests
Signed-off-by: Remi Lespinet
---
t/t4150-am.sh |
6 matches
Mail list logo
