Re: [PATCH 1/3] tree-walk: be more specific about corrupt tree errors

2016-09-26 Thread Jeff King
On Mon, Sep 26, 2016 at 09:01:15PM -0700, Junio C Hamano wrote: > > 5 files changed, 21 insertions(+), 7 deletions(-) > > create mode 100644 t/t1007/.gitattributes > > create mode 100644 t/t1007/tree-with-empty-filename > > create mode 100644 t/t1007/tree-with-malformed-mode > > I hate to

Re: [PATCH 1/3] tree-walk: be more specific about corrupt tree errors

2016-09-26 Thread Junio C Hamano
David Turner writes: > From: Jeff King > > When the tree-walker runs into an error, it just calls > die(), and the message is always "corrupt tree file". > However, we are actually covering several cases here; let's > give the user a hint about what

[PATCH 1/3] tree-walk: be more specific about corrupt tree errors

2016-09-26 Thread David Turner
From: Jeff King When the tree-walker runs into an error, it just calls die(), and the message is always "corrupt tree file". However, we are actually covering several cases here; let's give the user a hint about what happened. Let's also avoid using the word "corrupt", which