Re: [PATCH 1/4] diff.h: extend "flags" field to 64 bits because we're out of bits

2016-06-07 Thread stefan.naewe
Am 06.06.2016 um 13:16 schrieb Nguyễn Thái Ngọc Duy: > Current flags field is 32-bits, all used except one bit and we need one > more bit is needed for to toggle i-t-a behavior. The 9th bit could be Something's wrong here. Either drop the "is needed" or the "we need". > reused for this, but we

Re: [PATCH 1/4] diff.h: extend "flags" field to 64 bits because we're out of bits

2016-06-06 Thread Duy Nguyen
On Tue, Jun 7, 2016 at 2:45 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> Current flags field is 32-bits, all used except one bit and we need one >> more bit is needed for to toggle i-t-a behavior. The 9th bit could be >> reused for this,

Re: [PATCH 1/4] diff.h: extend "flags" field to 64 bits because we're out of bits

2016-06-06 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > Current flags field is 32-bits, all used except one bit and we need one > more bit is needed for to toggle i-t-a behavior. The 9th bit could be > reused for this, but we could just extend it to 64 bits now to give room > for more future flags.

[PATCH 1/4] diff.h: extend "flags" field to 64 bits because we're out of bits

2016-06-06 Thread Nguyễn Thái Ngọc Duy
Current flags field is 32-bits, all used except one bit and we need one more bit is needed for to toggle i-t-a behavior. The 9th bit could be reused for this, but we could just extend it to 64 bits now to give room for more future flags. gcc -Wconversion is used to catch assignments that truncate