Re: [PATCH 1/4] imap-send: add wrapper to get server credentials if needed

2017-08-07 Thread Junio C Hamano
Jeff King writes: > On Mon, Aug 07, 2017 at 09:55:56PM +0200, Nicolas Morey-Chaisemartin wrote: > >> > On the other hand, if we're hoping to get rid of this code in favor of >> > the curl-based approach, then it's not worth spending time on >> > cosmetic refactoring, as long as it still behaves c

Re: [PATCH 1/4] imap-send: add wrapper to get server credentials if needed

2017-08-07 Thread Jeff King
On Mon, Aug 07, 2017 at 09:55:56PM +0200, Nicolas Morey-Chaisemartin wrote: > > On the other hand, if we're hoping to get rid of this code in favor of > > the curl-based approach, then it's not worth spending time on > > cosmetic refactoring, as long as it still behaves correctly in the > > interi

Re: [PATCH 1/4] imap-send: add wrapper to get server credentials if needed

2017-08-07 Thread Nicolas Morey-Chaisemartin
Le 07/08/2017 à 21:42, Jeff King a écrit : > On Mon, Aug 07, 2017 at 07:18:32PM +0200, Martin Ågren wrote: > "cred.username" is checked further down, but now it will always be NULL, no? >>> You're right I missed this. >>> Not sure if this is needed though. >>> From what I understand thi

Re: [PATCH 1/4] imap-send: add wrapper to get server credentials if needed

2017-08-07 Thread Jeff King
On Mon, Aug 07, 2017 at 07:18:32PM +0200, Martin Ågren wrote: > >> "cred.username" is checked further down, but now it will always be NULL, > >> no? > > > > You're right I missed this. > > Not sure if this is needed though. > > From what I understand this means the username/password are store for

Re: [PATCH 1/4] imap-send: add wrapper to get server credentials if needed

2017-08-07 Thread Martin Ågren
On 7 August 2017 at 19:04, Nicolas Morey-Chaisemartin wrote: > > > Le 07/08/2017 à 18:30, Martin Ågren a écrit : >> On 7 August 2017 at 16:03, Nicolas Morey-Chaisemartin >> wrote: >>> Signed-off-by: Nicolas Morey-Chaisemartin >>> --- >>> imap-send.c | 38 -- >

Re: [PATCH 1/4] imap-send: add wrapper to get server credentials if needed

2017-08-07 Thread Nicolas Morey-Chaisemartin
Le 07/08/2017 à 18:30, Martin Ågren a écrit : > On 7 August 2017 at 16:03, Nicolas Morey-Chaisemartin > wrote: >> Signed-off-by: Nicolas Morey-Chaisemartin >> --- >> imap-send.c | 38 -- >> 1 file changed, 24 insertions(+), 14 deletions(-) >> >> diff --git a

Re: [PATCH 1/4] imap-send: add wrapper to get server credentials if needed

2017-08-07 Thread Martin Ågren
On 7 August 2017 at 16:03, Nicolas Morey-Chaisemartin wrote: > Signed-off-by: Nicolas Morey-Chaisemartin > --- > imap-send.c | 38 -- > 1 file changed, 24 insertions(+), 14 deletions(-) > > diff --git a/imap-send.c b/imap-send.c > index b2d0b849b..38b3c817e 10

[PATCH 1/4] imap-send: add wrapper to get server credentials if needed

2017-08-07 Thread Nicolas Morey-Chaisemartin
Signed-off-by: Nicolas Morey-Chaisemartin --- imap-send.c | 38 -- 1 file changed, 24 insertions(+), 14 deletions(-) diff --git a/imap-send.c b/imap-send.c index b2d0b849b..38b3c817e 100644 --- a/imap-send.c +++ b/imap-send.c @@ -926,6 +926,29 @@ static int au