Re: [PATCH 1/8] tag: Remove a TODO item from the test suite

2017-03-18 Thread Ævar Arnfjörð Bjarmason
On Sun, Mar 19, 2017 at 1:48 AM, Jakub Narębski wrote: > W dniu 18.03.2017 o 11:32, Ævar Arnfjörð Bjarmason pisze: > >> @@ -136,7 +135,6 @@ test_expect_success \ >> 'listing a tag using a matching pattern should output that tag' \ >> 'test $(git tag -l mytag) = mytag' >> >> -# todo: gi

Re: [PATCH 1/8] tag: Remove a TODO item from the test suite

2017-03-18 Thread Jakub Narębski
W dniu 18.03.2017 o 11:32, Ævar Arnfjörð Bjarmason pisze: > @@ -136,7 +135,6 @@ test_expect_success \ > 'listing a tag using a matching pattern should output that tag' \ > 'test $(git tag -l mytag) = mytag' > > -# todo: git tag -l now returns always zero, when fixed, change this test

Re: [PATCH 1/8] tag: Remove a TODO item from the test suite

2017-03-18 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > Change the test for "git tag -l" to not have an associated TODO > comment saying that it should return non-zero if there's no tags. > > This was added in commit ef5a6fb597 ("Add test-script for git-tag", > 2007-06-28) when the tests for "tag" were initially adde

[PATCH 1/8] tag: Remove a TODO item from the test suite

2017-03-18 Thread Ævar Arnfjörð Bjarmason
Change the test for "git tag -l" to not have an associated TODO comment saying that it should return non-zero if there's no tags. This was added in commit ef5a6fb597 ("Add test-script for git-tag", 2007-06-28) when the tests for "tag" were initially added, but at this point changing this would be