Re: [PATCH 1/8] trace2: create new combined trace facility

2018-09-05 Thread Jeff Hostetler
On 9/4/2018 6:30 PM, Junio C Hamano wrote: Stefan Beller writes: The API defines both fixed-field and printf-style functions. The trace2 performance tracing includes thread-specific function nesting and timings. So this only adds the new API, and we need to merge the TRACE into the

Re: [PATCH 1/8] trace2: create new combined trace facility

2018-09-05 Thread Jeff Hostetler
On 9/4/2018 6:12 PM, Stefan Beller wrote: Create GIT_TR2 trace-key to replace GIT_TRACE, GIT_TR2_PERFORMANCE to replace GIT_TRACE_PERFORMANCE, and a new trace-key GIT_TR2_EVENT to generate JSON data for telemetry purposes. Other structured formats can easily be added later using this new

Re: [PATCH 1/8] trace2: create new combined trace facility

2018-09-04 Thread Junio C Hamano
Stefan Beller writes: >> The API defines both fixed-field and printf-style functions. >> >> The trace2 performance tracing includes thread-specific function >> nesting and timings. > > So this only adds the new API, and we need to merge the TRACE > into the TRACE2 later? If this is a rhetorical

Re: [PATCH 1/8] trace2: create new combined trace facility

2018-09-04 Thread Stefan Beller
> Create GIT_TR2 trace-key to replace GIT_TRACE, GIT_TR2_PERFORMANCE to > replace GIT_TRACE_PERFORMANCE, and a new trace-key GIT_TR2_EVENT to > generate JSON data for telemetry purposes. Other structured formats > can easily be added later using this new existing model. So the idea is to use the

Re: [PATCH 1/8] trace2: create new combined trace facility

2018-08-31 Thread Derrick Stolee
On 8/31/2018 12:49 PM, Jeff Hostetler via GitGitGadget wrote: + if (tr2key_trace_want(_event)) { + struct tr2tls_thread_ctx *ctx = tr2tls_get_self(); + if (ctx->nr_open_regions <= tr2env_event_depth_wanted) { This should also compare to TR2_MAX_REGION_NESTING

[PATCH 1/8] trace2: create new combined trace facility

2018-08-31 Thread Jeff Hostetler via GitGitGadget
From: Jeff Hostetler Create trace2 API allowing event-based tracing. This will hopefully eventually replace the existing trace API. Create GIT_TR2 trace-key to replace GIT_TRACE, GIT_TR2_PERFORMANCE to replace GIT_TRACE_PERFORMANCE, and a new trace-key GIT_TR2_EVENT to generate JSON data for