Re: [PATCH 1.5/8] connect: die when a capability line comes after a ref

2017-09-20 Thread Junio C Hamano
Brandon Williams writes: >> Or is this only for v2 clients, and we've changed the protocol but >> get_remote_heads() just needs to be updated, too? > > A client which didn't request protocol v1 (I'm calling the current > protocol v0, and v1 is just v0 with the initial response

Re: [PATCH 1.5/8] connect: die when a capability line comes after a ref

2017-09-20 Thread Jonathan Nieder
Brandon Williams wrote: > On 09/20, Jeff King wrote: >> (For that matter, could we just be checking whether *list is NULL?) > > True, that would probably be the better way to do this. Nice idea, thank you. That doesn't capture a few other cases of pkts that aren't supposed to come before the

Re: [PATCH 1.5/8] connect: die when a capability line comes after a ref

2017-09-20 Thread Brandon Williams
On 09/20, Jeff King wrote: > On Wed, Sep 20, 2017 at 11:48:32AM -0700, Brandon Williams wrote: > > > Commit eb398797c (connect: advertized capability is not a ref, > > 2016-09-09) taught 'get_remote_heads()' to recognize that the > > 'capabilities^{}' line isn't a ref but required that the > >

Re: [PATCH 1.5/8] connect: die when a capability line comes after a ref

2017-09-20 Thread Jeff King
On Wed, Sep 20, 2017 at 11:48:32AM -0700, Brandon Williams wrote: > Commit eb398797c (connect: advertized capability is not a ref, > 2016-09-09) taught 'get_remote_heads()' to recognize that the > 'capabilities^{}' line isn't a ref but required that the > 'capabilities^{}' line came during the

[PATCH 1.5/8] connect: die when a capability line comes after a ref

2017-09-20 Thread Brandon Williams
Commit eb398797c (connect: advertized capability is not a ref, 2016-09-09) taught 'get_remote_heads()' to recognize that the 'capabilities^{}' line isn't a ref but required that the 'capabilities^{}' line came during the first response from the server. A future patch will introduce a version