Re: [PATCH 10/12] grep: change the internal PCRE macro names to be PCRE1

2017-04-11 Thread Jeff King
On Tue, Apr 11, 2017 at 12:51:09PM +0200, Ævar Arnfjörð Bjarmason wrote: > > Yeah, I think it's nice to keep the build-time knobs compatible. In the > > long run I assume we'll want to add a USE_LIBPCRE1 flag and USE_LIBPCRE > > just becomes a synonym for it (in fact, we could do that in this > >

Re: [PATCH 10/12] grep: change the internal PCRE macro names to be PCRE1

2017-04-11 Thread Ævar Arnfjörð Bjarmason
On Tue, Apr 11, 2017 at 12:35 PM, Jeff King wrote: > On Sat, Apr 08, 2017 at 01:25:04PM +, Ævar Arnfjörð Bjarmason wrote: > >> Change the internal USE_LIBPCRE define, & build options flag to use a >> naming convention ending in PCRE1, without changing the long-standing >>

Re: [PATCH 10/12] grep: change the internal PCRE macro names to be PCRE1

2017-04-11 Thread Jeff King
On Sat, Apr 08, 2017 at 01:25:04PM +, Ævar Arnfjörð Bjarmason wrote: > Change the internal USE_LIBPCRE define, & build options flag to use a > naming convention ending in PCRE1, without changing the long-standing > USE_LIBPCRE Makefile flag which enables this code. > > This is for

[PATCH 10/12] grep: change the internal PCRE macro names to be PCRE1

2017-04-08 Thread Ævar Arnfjörð Bjarmason
Change the internal USE_LIBPCRE define, & build options flag to use a naming convention ending in PCRE1, without changing the long-standing USE_LIBPCRE Makefile flag which enables this code. This is for preparation for libpcre2 support where having things like USE_LIBPCRE and USE_LIBPCRE2 in any