Re: [PATCH 10/20] git-submodule.sh: avoid test cond -a/-o cond

2014-06-10 Thread Johannes Sixt
Am 6/10/2014 1:23, schrieb Junio C Hamano: Elia Pinto gitter.spi...@gmail.com writes: @@ -1059,13 +1059,17 @@ cmd_summary() { while read mod_src mod_dst sha1_src sha1_dst status sm_path do # Always show modules deleted or type-changed

Re: [PATCH 10/20] git-submodule.sh: avoid test cond -a/-o cond

2014-06-10 Thread Johannes Sixt
Am 6/10/2014 8:52, schrieb Johannes Sixt: Am 6/10/2014 1:23, schrieb Junio C Hamano: Elia Pinto gitter.spi...@gmail.com writes: @@ -1059,13 +1059,17 @@ cmd_summary() { while read mod_src mod_dst sha1_src sha1_dst status sm_path do # Always show

Re: [PATCH 10/20] git-submodule.sh: avoid test cond -a/-o cond

2014-06-09 Thread Junio C Hamano
Elia Pinto gitter.spi...@gmail.com writes: @@ -1059,13 +1059,17 @@ cmd_summary() { while read mod_src mod_dst sha1_src sha1_dst status sm_path do # Always show modules deleted or type-changed (blob-module) - test $status

[PATCH 10/20] git-submodule.sh: avoid test cond -a/-o cond

2014-06-06 Thread Elia Pinto
The construct is error-prone; test being built-in in most modern shells, the reason to avoid test cond test cond spawning one extra process by using a single test cond -a cond no longer exists. Signed-off-by: Elia Pinto gitter.spi...@gmail.com --- git-submodule.sh | 32