Re: [PATCH 11/22] sequencer: get rid of the subcommand field

2016-09-01 Thread Johannes Schindelin
Hi Kuba, On Wed, 31 Aug 2016, Jakub Narębski wrote: > W dniu 29.08.2016 o 10:05, Johannes Schindelin pisze: > > > While at it, ensure that the subcommands return an error code so that > > they do not have to die() all over the place (bad practice for library > > functions...). > > This perhaps

Re: [PATCH 11/22] sequencer: get rid of the subcommand field

2016-08-31 Thread Jakub Narębski
W dniu 29.08.2016 o 10:05, Johannes Schindelin pisze: > The subcommands are used exactly once, at the very beginning of > sequencer_pick_revisions(), to determine what to do. This is an > unnecessary level of indirection: we can simply call the correct > function to begin with. So let's do that.

[PATCH 11/22] sequencer: get rid of the subcommand field

2016-08-29 Thread Johannes Schindelin
The subcommands are used exactly once, at the very beginning of sequencer_pick_revisions(), to determine what to do. This is an unnecessary level of indirection: we can simply call the correct function to begin with. So let's do that. While at it, ensure that the subcommands return an error code