Re: [PATCH 11/28] attr: (re)introduce git_check_attr() and struct git_attr_check

2016-10-11 Thread Junio C Hamano
Brandon Williams writes: > On 10/10, Stefan Beller wrote: >> From: Junio C Hamano >> >> A common pattern to check N attributes for many paths is to >> >> (1) prepare an array A of N git_attr_check_elem items; >> (2) call git_attr() to intern the N attribute names and fill A; > > Does the wor

Re: [PATCH 11/28] attr: (re)introduce git_check_attr() and struct git_attr_check

2016-10-11 Thread Brandon Williams
On 10/10, Stefan Beller wrote: > From: Junio C Hamano > > A common pattern to check N attributes for many paths is to > > (1) prepare an array A of N git_attr_check_elem items; > (2) call git_attr() to intern the N attribute names and fill A; Does the word 'intern' here mean internalize? It

[PATCH 11/28] attr: (re)introduce git_check_attr() and struct git_attr_check

2016-10-10 Thread Stefan Beller
From: Junio C Hamano A common pattern to check N attributes for many paths is to (1) prepare an array A of N git_attr_check_elem items; (2) call git_attr() to intern the N attribute names and fill A; (3) repeatedly call git_check_attrs() for path with N and A; A look-up for these N attribute