Re: [PATCH 14/15] git-am.sh: replace using expr for arithmetic operations with the equivalent shell builtin

2016-02-04 20:33 GMT+01:00 Junio C Hamano : > As pointed out already, quoting of "$this" inside the arithmetic > expansion would not work very well, so [14/15] needs fixing. > > I do not see 01/15 thru 13/15 here, by the way. Is it just me? Excuse me, everyone. Yesterday was a

Re: [PATCH 14/15] git-am.sh: replace using expr for arithmetic operations with the equivalent shell builtin

Hi Elia, On Thu, 4 Feb 2016, Elia Pinto wrote: > - this=$(expr "$this" + 1) > + this=$(( "$this" + 1 )) Why the funny spaces? We do not do that anywhere in the existing code except in three places (2x filter-branch, 1x rebase--interactive, all three *not*

Re: [PATCH 14/15] git-am.sh: replace using expr for arithmetic operations with the equivalent shell builtin

2016-02-04 12:14 GMT+01:00 Johannes Schindelin : > Hi Elia, > > On Thu, 4 Feb 2016, Elia Pinto wrote: > >> - this=$(expr "$this" + 1) >> + this=$(( "$this" + 1 )) > > Why the funny spaces? We do not do that anywhere in the

Re: [PATCH 14/15] git-am.sh: replace using expr for arithmetic operations with the equivalent shell builtin

Hi Elia, On Thu, 4 Feb 2016, Elia Pinto wrote: > 2016-02-04 12:14 GMT+01:00 Johannes Schindelin : > > Hi Elia, > > > > On Thu, 4 Feb 2016, Elia Pinto wrote: > > > >> - this=$(expr "$this" + 1) > >> + this=$(( "$this" + 1 )) > >

[PATCH 14/15] git-am.sh: replace using expr for arithmetic operations with the equivalent shell builtin

expr is considered generally antiquated. It is best to use for arithmetic operations the shell $((..)). To quote POSIX: "The expr utility has a rather difficult syntax [...] In many cases, the arithmetic and string features provided as part of the shell command language are easier to use than

Re: [PATCH 14/15] git-am.sh: replace using expr for arithmetic operations with the equivalent shell builtin

As pointed out already, quoting of "$this" inside the arithmetic expansion would not work very well, so [14/15] needs fixing. I do not see 01/15 thru 13/15 here, by the way. Is it just me? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to

Re: [PATCH 14/15] git-am.sh: replace using expr for arithmetic operations with the equivalent shell builtin

On Thu, Feb 4, 2016 at 2:33 PM, Junio C Hamano wrote: > As pointed out already, quoting of "$this" inside the arithmetic > expansion would not work very well, so [14/15] needs fixing. > > I do not see 01/15 thru 13/15 here, by the way. Is it just me? I didn't receive them

Re: [PATCH 14/15] git-am.sh: replace using expr for arithmetic operations with the equivalent shell builtin

On which version did you base your patches? git-am.sh is no more since 2015-08-04, (it was moved to contrib/examples/git-am.sh as part of the rewrite of am in C) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo