Re: [PATCH 15/18] read-cache, remove_marked_cache_entries: wipe selected submodules.

Stefan Beller writes: > Side-question: > Is there some doc (commit message), that explains the difference > between CE_REMOVE and CE_WT_REMOVE ? That's something you need to ask Duy, I think, as it was introduced at e663db2f ("unpack-trees(): add CE_WT_REMOVE to remove on

Re: [PATCH 15/18] read-cache, remove_marked_cache_entries: wipe selected submodules.

On Tue, Mar 7, 2017 at 5:14 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> submodule_from_ce returns always NULL, when such flag is not given. >> From 10/18: >> >> +const struct submodule *submodule_from_ce(const struct cache_entry *ce) >> +{ >> +

Re: [PATCH 15/18] read-cache, remove_marked_cache_entries: wipe selected submodules.

Stefan Beller writes: > submodule_from_ce returns always NULL, when such flag is not given. > From 10/18: > > +const struct submodule *submodule_from_ce(const struct cache_entry *ce) > +{ > + if (!S_ISGITLINK(ce->ce_mode)) > + return NULL; > + > + if

Re: [PATCH 15/18] read-cache, remove_marked_cache_entries: wipe selected submodules.

On Tue, Mar 7, 2017 at 2:42 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> Signed-off-by: Stefan Beller >> + submodule_move_head(sub->path, "HEAD", NULL, \ > > What is this backslash doing here? I am still bad at

Re: [PATCH 15/18] read-cache, remove_marked_cache_entries: wipe selected submodules.

Stefan Beller writes: > Signed-off-by: Stefan Beller > --- > read-cache.c | 27 +-- > 1 file changed, 25 insertions(+), 2 deletions(-) > > diff --git a/read-cache.c b/read-cache.c > index 9054369dd0..9a2abacf7a 100644 > ---

[PATCH 15/18] read-cache, remove_marked_cache_entries: wipe selected submodules.

Signed-off-by: Stefan Beller --- read-cache.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/read-cache.c b/read-cache.c index 9054369dd0..9a2abacf7a 100644 --- a/read-cache.c +++ b/read-cache.c @@ -18,6 +18,8 @@ #include

[PATCH 15/18] read-cache, remove_marked_cache_entries: wipe selected submodules.

Signed-off-by: Stefan Beller --- read-cache.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/read-cache.c b/read-cache.c index 9054369dd0..9a2abacf7a 100644 --- a/read-cache.c +++ b/read-cache.c @@ -18,6 +18,8 @@ #include