Re: [PATCH 18/19] submodule: don't add submodule as odb for push

2018-10-11 Thread Stefan Beller
> Do you know if pushing of submodules is exercised by any test? t5531-deep-submodule-push.sh (all of them) t5545-push-options.sh (ok 4 - push options and submodules)

Re: [PATCH 18/19] submodule: don't add submodule as odb for push

2018-10-11 Thread Jonathan Tan
> The submodule was added as an alternative in eb21c732d6 (push: teach > --recurse-submodules the on-demand option, 2012-03-29), but was > not explained, why. > > In similar code, submodule_has_commits, the submodule is added as an > alternative to perform a quick check if we need to dive into the

[PATCH 18/19] submodule: don't add submodule as odb for push

2018-10-11 Thread Stefan Beller
The submodule was added as an alternative in eb21c732d6 (push: teach --recurse-submodules the on-demand option, 2012-03-29), but was not explained, why. In similar code, submodule_has_commits, the submodule is added as an alternative to perform a quick check if we need to dive into the submodule.