Re: [PATCH 2/2] fast-export: refactor get_tags_and_duplicates()

2013-09-03 Thread Junio C Hamano
Felipe Contreras felipe.contre...@gmail.com writes: Split into a separate helper function get_commit() so that the part that finds the relevant commit, and the part that does something with it (handle tag object, etc.) are in different places. No functional changes. Actually, the old code

Re: [PATCH 2/2] fast-export: refactor get_tags_and_duplicates()

2013-09-03 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Felipe Contreras felipe.contre...@gmail.com writes: Split into a separate helper function get_commit() so that the part that finds the relevant commit, and the part that does something with it (handle tag object, etc.) are in different places. No

[PATCH 2/2] fast-export: refactor get_tags_and_duplicates()

2013-09-01 Thread Felipe Contreras
Split into a separate helper function get_commit() so that the part that finds the relevant commit, and the part that does something with it (handle tag object, etc.) are in different places. No functional changes. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com ---