Re: [PATCH 2/2] git-svn: allow empty email-address in authors-prog and authors-file

Am 05.03.2018 um 10:37 schrieb Andreas Heiduk: > 2018-03-05 2:42 GMT+01:00 Eric Sunshine : >> On Sun, Mar 4, 2018 at 6:22 AM, Andreas Heiduk wrote: >>> --- >>> diff --git a/perl/Git/SVN.pm b/perl/Git/SVN.pm >>> @@ -1482,7 +1482,6 @@ sub

Re: [PATCH 2/2] git-svn: allow empty email-address in authors-prog and authors-file

On Mon, Mar 5, 2018 at 4:37 AM, Andreas Heiduk wrote: > 2018-03-05 2:42 GMT+01:00 Eric Sunshine : >> On Sun, Mar 4, 2018 at 6:22 AM, Andreas Heiduk wrote: >>> The email address in --authors-file and --authors-prog can be empty but

Re: [PATCH 2/2] git-svn: allow empty email-address in authors-prog and authors-file

Andreas Heiduk wrote: > 2018-03-05 2:42 GMT+01:00 Eric Sunshine : > > Doesn't such a behavior change deserve being documented (and possibly > > tests)? > > The old behaviour was neither documented nor tested - the > change did not break any test

Re: [PATCH 2/2] git-svn: allow empty email-address in authors-prog and authors-file

2018-03-05 2:42 GMT+01:00 Eric Sunshine : > On Sun, Mar 4, 2018 at 6:22 AM, Andreas Heiduk wrote: >> The email address in --authors-file and --authors-prog can be empty but >> git-svn translated it into a syntethic email address in the form >>

Re: [PATCH 2/2] git-svn: allow empty email-address in authors-prog and authors-file

On Sun, Mar 4, 2018 at 6:22 AM, Andreas Heiduk wrote: > The email address in --authors-file and --authors-prog can be empty but > git-svn translated it into a syntethic email address in the form > $USERNAME@$REPO_UUID. Now git-svn behaves like git-commit: If the email > is

[PATCH 2/2] git-svn: allow empty email-address in authors-prog and authors-file

The email address in --authors-file and --authors-prog can be empty but git-svn translated it into a syntethic email address in the form $USERNAME@$REPO_UUID. Now git-svn behaves like git-commit: If the email is explicitly set to the empty string, the commit does not contain an email address.