Re: [PATCH 2/2] mingw: fix mingw_open_append to work with named pipes

2018-09-10 Thread Jeff Hostetler
On 9/10/2018 12:42 PM, Junio C Hamano wrote: Jeff Hostetler writes: Yeah, this whole thing is a little under-documented for my tastes. Let's leave it as you have it. I'll re-roll with a fix to route named pipes to the existing _wopen() code. OK, I have these two patches in 'next', but

Re: [PATCH 2/2] mingw: fix mingw_open_append to work with named pipes

2018-09-10 Thread Junio C Hamano
Jeff Hostetler writes: > Yeah, this whole thing is a little under-documented for my tastes. > Let's leave it as you have it. I'll re-roll with a fix to route > named pipes to the existing _wopen() code. OK, I have these two patches in 'next', but let's postpone it for now. Windows port will

Re: [PATCH 2/2] mingw: fix mingw_open_append to work with named pipes

2018-09-10 Thread Jeff Hostetler
On 9/8/2018 2:31 PM, Johannes Sixt wrote: Am 08.09.2018 um 11:26 schrieb Johannes Sixt: Am 07.09.2018 um 20:19 schrieb Jeff Hostetler via GitGitGadget: diff --git a/compat/mingw.c b/compat/mingw.c index 858ca14a57..ef03bbe5d2 100644 --- a/compat/mingw.c +++ b/compat/mingw.c @@ -355,7 +355,7

Re: [PATCH 2/2] mingw: fix mingw_open_append to work with named pipes

2018-09-08 Thread Johannes Sixt
Am 08.09.2018 um 11:26 schrieb Johannes Sixt: Am 07.09.2018 um 20:19 schrieb Jeff Hostetler via GitGitGadget: diff --git a/compat/mingw.c b/compat/mingw.c index 858ca14a57..ef03bbe5d2 100644 --- a/compat/mingw.c +++ b/compat/mingw.c @@ -355,7 +355,7 @@ static int mingw_open_append(wchar_t const

Re: [PATCH 2/2] mingw: fix mingw_open_append to work with named pipes

2018-09-08 Thread Johannes Sixt
Am 07.09.2018 um 20:19 schrieb Jeff Hostetler via GitGitGadget: From: Jeff Hostetler Signed-off-by: Jeff Hostetler --- compat/mingw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compat/mingw.c b/compat/mingw.c index 858ca14a57..ef03bbe5d2 100644 --- a/compat/mingw.c

[PATCH 2/2] mingw: fix mingw_open_append to work with named pipes

2018-09-07 Thread Jeff Hostetler via GitGitGadget
From: Jeff Hostetler Signed-off-by: Jeff Hostetler --- compat/mingw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compat/mingw.c b/compat/mingw.c index 858ca14a57..ef03bbe5d2 100644 --- a/compat/mingw.c +++ b/compat/mingw.c @@ -355,7 +355,7 @@ static int