[PATCH 2/2] pull: clarify the large { ... } form

Remove the large { ... } form, as the block can be confused with a function block. Use a simple if-condition instead. No functional changes. Signed-off-by: Ramkumar Ramachandra artag...@gmail.com --- git-pull.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 2/2] pull: clarify the large { ... } form

Ramkumar Ramachandra artag...@gmail.com writes: -test true = $rebase { +if test true = $rebase; then Use a newline, not a ';'. See CodingGuideLines: - Do not write control structures on a single line with semicolon. then should be on the next line for if statements, and do should be

Re: [PATCH 2/2] pull: clarify the large { ... } form

Matthieu Moy wrote: Use a newline, not a ';'. Thanks. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html