Re: [PATCH 2/2] read-cache: fix reading of split index

2015-03-24 Thread Junio C Hamano
Duy Nguyen writes: > Thank you for catching this. I was about to write "would be nice to > point out what tests fail so the reviewer has easier time trying > themselves", but whoa.. quite a few of them! > > May I suggest a slight modification. Even though stage info is messed > up before the inde

Re: [PATCH 2/2] read-cache: fix reading of split index

2015-03-24 Thread Thomas Gummerer
On 03/24, Duy Nguyen wrote: > On Sat, Mar 21, 2015 at 4:43 AM, Thomas Gummerer wrote: > > The split index extension uses ewah bitmaps to mark index entries as > > deleted, instead of removing them from the index directly. This can > > result in an on-disk index, in which entries of stage #0 and h

Re: [PATCH 2/2] read-cache: fix reading of split index

2015-03-24 Thread Duy Nguyen
On Sat, Mar 21, 2015 at 4:43 AM, Thomas Gummerer wrote: > The split index extension uses ewah bitmaps to mark index entries as > deleted, instead of removing them from the index directly. This can > result in an on-disk index, in which entries of stage #0 and higher > stages appear, which are rem

[PATCH 2/2] read-cache: fix reading of split index

2015-03-20 Thread Thomas Gummerer
The split index extension uses ewah bitmaps to mark index entries as deleted, instead of removing them from the index directly. This can result in an on-disk index, in which entries of stage #0 and higher stages appear, which are removed later when the index bases are merged. 15999d0 read_index_f