Re: [PATCH 2/2] rebase: turn on progress option by default for format-patch

2017-06-03 Thread Junio C Hamano
Jeff King writes: > ... > That explains why you want to pass "-q" in the other hunk; to > countermand the explicit --progress here. But if we separate the two as > I mentioned above, you'd want logic more like: > > if test -t 2 && test "$GIT_QUIET" != "t" > git_format_patch_opt="$git_form

Re: [PATCH 2/2] rebase: turn on progress option by default for format-patch

2017-06-01 Thread Johannes Schindelin
Hi Stefan, On Wed, 31 May 2017, Stefan Beller wrote: > On Wed, May 31, 2017 at 8:04 AM, Kevin Willford wrote: > > This change passes the progress option of format-patch by > > default and passes the -q --quiet option through to the > > format-patch call so that it is respected as well. > > This

Re: [PATCH 2/2] rebase: turn on progress option by default for format-patch

2017-05-31 Thread Jeff King
On Wed, May 31, 2017 at 08:04:27AM -0700, Kevin Willford wrote: > This change passes the progress option of format-patch by > default and passes the -q --quiet option through to the > format-patch call so that it is respected as well. That makes sense. Is it a bug that we aren't propagating "-q"

Re: [PATCH 2/2] rebase: turn on progress option by default for format-patch

2017-05-31 Thread Stefan Beller
On Wed, May 31, 2017 at 12:46 PM, Kevin Willford wrote: > > I thought about that and certainly could do it but I have found it nice to > have the number of patches that are generated in the output even for a small > number or commits. For example when I run a `git rebase master` and expect >

RE: [PATCH 2/2] rebase: turn on progress option by default for format-patch

2017-05-31 Thread Kevin Willford
> -Original Message- > From: Stefan Beller [mailto:sbel...@google.com] > Sent: Wednesday, May 31, 2017 1:09 PM > To: Kevin Willford > Cc: git@vger.kernel.org; Junio C Hamano ; Kevin > Willford > Subject: Re: [PATCH 2/2] rebase: turn on progress option by defau

Re: [PATCH 2/2] rebase: turn on progress option by default for format-patch

2017-05-31 Thread Stefan Beller
On Wed, May 31, 2017 at 8:04 AM, Kevin Willford wrote: > This change passes the progress option of format-patch by > default and passes the -q --quiet option through to the > format-patch call so that it is respected as well. This is not conflicting with Johannes rewrite of rebase in C? (rebase i

[PATCH 2/2] rebase: turn on progress option by default for format-patch

2017-05-31 Thread Kevin Willford
This change passes the progress option of format-patch by default and passes the -q --quiet option through to the format-patch call so that it is respected as well. Signed-off-by: Kevin Willford --- git-rebase--am.sh | 5 +++-- git-rebase.sh | 2 ++ 2 files changed, 5 insertions(+), 2 deleti